Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliments ✨ #41

Open
joe-dev-public opened this issue Jul 1, 2022 · 2 comments
Open

Compliments ✨ #41

joe-dev-public opened this issue Jul 1, 2022 · 2 comments

Comments

@joe-dev-public
Copy link

joe-dev-public commented Jul 1, 2022

  • Nice and easy to get a local dev copy up and running (git clone ..., npm install, npm run dev).
  • Clean code structure and layout 🧽
  • Good use of React components 🧩 (Breadcrumb, Search, ChoiceButton, etc.)
  • Looks like the project board is getting well used 😎
  • Good commit messages and PR conversations! 😊
  • Tailwind getting used in components 👍
  • "Found" recycle point info? 👀
  • Clear use of useState and "controlled components" ✔️ (first mentioned in this FAC workshop)
  • Jest tests (in progress :)
@minju25kim
Copy link

import { MapContainer, TileLayer, Marker, Popup, useMap } from 'react-leaflet'

Nice that you found this react leaflet

Nice name as Breadcrumb, nice way to show path.

@Glombort
Copy link
Contributor

Glombort commented Jul 1, 2022

  • We do luv a nice clean easy reading modular code
  • Components well re-used everywhere making them super useful
  • Good choice of area for recycling points, means i can go to them :)

p.s. I want 25% of the company for my contributions to this repo 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants