Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling consistency #9

Open
Joepock123 opened this issue Oct 22, 2020 · 0 comments
Open

Styling consistency #9

Joepock123 opened this issue Oct 22, 2020 · 0 comments

Comments

@Joepock123
Copy link

  • Lots of styling for each styled component (is the styling copied from Figma?) There may be some styles that are common. Styled components are in JS we can utilise variables for things such as spacings, breakpoints, colours by importing them from designated files. Like global css styles this can help keep our styling consistent across the app and means we only need to change the value in one place.
  • For small components the styled components can go in the same file instead of a separate .styles file. Generally I follow that pattern even with bigger components as it gets rid of loads of files (although it's a preference thing!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant