Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider specifying minimum node version #61

Open
Roger-Heathcote opened this issue Apr 3, 2020 · 0 comments
Open

Consider specifying minimum node version #61

Roger-Heathcote opened this issue Apr 3, 2020 · 0 comments
Labels
code review tip wontfix This will not be worked on

Comments

@Roger-Heathcote
Copy link

Roger-Heathcote commented Apr 3, 2020

You have specified a minimum version in your package json with...

    "engines": {
       "node": "12.16.x"
   },

That's great but I think it only applies to Heroku, local installs with npm i do not enforce it.
It might be a good idea to mention the minimum version in you readme, and/or, create an .nvmrc
file in your project root so NVM users will automatically switch to right version.

As an example this error happens on node 10...
Server error when trying to access
http://localhost:3000/create-tool
const data = Object.fromEntries(searchParams)
TypeError: Object.fromEntries is not a function

Of course you may notice we forgot to do this ourselves so sorry if you've been struggling to get our code to run!

@jackherizsmith jackherizsmith added the wontfix This will not be worked on label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review tip wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants