Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm i #74

Open
Ivo-Evans opened this issue May 29, 2020 · 1 comment
Open

npm i #74

Ivo-Evans opened this issue May 29, 2020 · 1 comment
Labels
code review enhancement New feature or request

Comments

@Ivo-Evans
Copy link
Member

installing dependencies is quite complicated because there's three npm packages (parent and two children) - maybe in the parent's package.json you could define a custom install command that installed all three, like npm i && cd server-api && npm i && cd ../client-app && npm i. I added this to scripts and it worked!

  "scripts": {
    "start": "node server.js",
    "test": "JWT_SECRET=mysecret PGDATABASE=travis_ci_test jest --coverage=true",
    "initdb": "node server-api/db/build.js",
    "deploy": "git subtree push --prefix server-api heroku master",
    "full-install": "npm i && cd server-api && npm i && cd ../client-app && npm i"
  },

(also would be helpful if in the ReadMe if you make it more clear/bold that you need to do npm install three times!!) (Vatsal)

@Ivo-Evans Ivo-Evans added enhancement New feature or request code review labels May 29, 2020
@Joepock123
Copy link
Collaborator

Run npm i on your terminal to install dependencies in the
client-app/
server-api/
Root folder

Ye sorry guys maybe this could have been written a little more clearly as that is what I was getting at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants