Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor core module to use dependency inversion principle #37

Open
fabiangeisler opened this issue Oct 10, 2023 · 1 comment
Open

Refactor core module to use dependency inversion principle #37

fabiangeisler opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@fabiangeisler
Copy link
Owner

  • pyshotgrid version: v1.0.1

Description

Currently the core module is a giant monolith which I build, because I ran into massive import loop issues. Turns out by using the dependency inversion principle this could be avoided and the code could be reorganised again. I would like to implement it for readability alone but I can image this will have some other benefits too.
@fabiangeisler fabiangeisler added the enhancement New feature or request label Oct 10, 2023
@fabiangeisler
Copy link
Owner Author

Turns out it is not as easy as I thought it would be. Since we have a somewhat bidirectional relation ship between the classes the interface approach kind of falls apart. Need to put more research into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabiangeisler