Thanks a lot for the nice PR Hugo! 👍

I'm hesitant to merge, just because I'm unsure how many people still rely on python 2.7 in there pipelines. I only now, that eco-deploy is used in many different setups and teams.

Please help me understand your motivation for creating this a bit better. Is there another reason for dropping support, except for clean up and dropping the unsupported Python version? I'm just wondering, if it made issues for you, too?

Thanks a lot & best wishes from Berlin
Fabian

Hi!

My main motivation is to help the Python community to fully move on to Python 3, which makes maintenance easier and allows to use newer syntax and features. Python 2 is no longer supported (2.5 years EOL by now) and for security we should encourage users to upgrade too -- there's been no security updates in Python many libraries have dropped it too, meaning no security updates there too.

There's a bit of a network effect too: "I can't drop support yet because package X is depending on me and they still want 2.7". It's better for Python as a whole to move on.

More concretely: issue #198 requested dropping 2.7 because they ran into an error deploying on 2.7 due to a boto3 issue.

If you want to keep supporting 2.7, that's totally fine! Feel free to close this PR.

I'm hesitant to merge, just because I'm unsure how many people still rely on python 2.7 in there pipelines. I only now, that eco-deploy is used in many different setups and teams.

For what it's worth, here's the pip installs for ecs-deploy from PyPI for June 2022, showing low numbers for 2.7:

Source: pip install -U pypistats && pypistats python_minor ecs-deploy --last-month

Good morning Hugo,

thanks a lot for your detailed answer and please apologize my late response. I totally support the effort to help the community to fully move on to Python 3 and appreciate your effort in your PR 🙌 I will definitely merge it, I'm just thinking of giving a quick deprecation notice before, for those 2.7er's who do not pin to a version and potentially run into a broken build pipeline 😉

I did not know about pypistats yet and I love it, it's super helpful, thanks for sharing!

Best
Fabian

Morning! No need to apologise, we're nearly all volunteers! This isn't urgent so take your time :)

Deprecation sounds reasonable, although I should also mention the python_requires='>=3.5 line.

With modern pip, it will only install a package with that line when using Python 3.5+.

For anyone using 2.7, pip will find the next oldest version. So this people still on 2.7 install a compatible package.

That's very good to know (pip) - learning a lot in this PR 🙂

I'm going to close this because by now there are 30 conflicts, and it will be easier to start again from scratch. If you like, I'm happy to re-do it when you're ready, shouldn't be too hard. 👍