Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type-2 Fisher in KFAC #49

Closed
runame opened this issue Oct 30, 2023 · 5 comments · Fixed by #56
Closed

Support type-2 Fisher in KFAC #49

runame opened this issue Oct 30, 2023 · 5 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request

Comments

@runame
Copy link
Collaborator

runame commented Oct 30, 2023

As opposed to using MC samples from the model's predictive distribution.

@runame runame added the enhancement New feature or request label Oct 30, 2023
@f-dangel
Copy link
Owner

Question: Is this already implemented in curvlinops.GGNLinearOperator?

@runame
Copy link
Collaborator Author

runame commented Oct 30, 2023

I don't think so, because curvlinops.GGNLinearOperator computes the exact GGN/Fisher, whereas this issue request a KFAC approximation using one backward pass per output dimension (see the implementation in ASDL as an example) to compute the gradients. I realize that the naming of the issue is a bit confusing, since it says "exact Fisher/GGN".

@f-dangel
Copy link
Owner

Oh okay, so this is sampling gradients versus using the columns of the loss-output Hessian's matrix square root? (I think in BackPACK this corresponds to KFLR)

@runame
Copy link
Collaborator Author

runame commented Oct 30, 2023

Yeah, that sounds correct.

@f-dangel
Copy link
Owner

I was trying to find a meaningful title for this. I could not find it on the internet, but believe the gradient-sampling-based estimation of the Fisher is called 'type-1', whereas the loss-Hessian-based estimation of the Fisher is called 'type-2'. Maybe @yorkerlin can help us out on this one.

@f-dangel f-dangel changed the title Support the exact Fisher/GGN in KFAC Support type-2 Fisher in KFAC Oct 30, 2023
@runame runame self-assigned this Nov 2, 2023
@runame runame linked a pull request Nov 7, 2023 that will close this issue
@f-dangel f-dangel closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants