Inconsistency with null and empty fragment in URI

[OptimumCode]

Hi,

I have noticed that the URI with an empty (not null) fragment parsed from the string is not equal to a URI with an empty fragment created with Uri.Builder (the URI created from the builder does not have # in the end if an empty fragment was set).

I would think that if a fragment is empty the # should be added at the end of the URI string representation.

If you agree, I will create a PR with changes and tests.

Here you can find a small example to reproduce the case:

import com.eygraber.uri.Uri
import io.kotest.assertions.assertSoftly
import io.kotest.core.spec.style.FunSpec
import io.kotest.matchers.shouldBe

class UriTest : FunSpec() {
  init {
    test("uri from string with empty fragment is not the same as build uri with empty fragment") {
      val fromStrWithEmptyFragment = Uri.parse("https://test.com#")
      val fromStrWithNullFragment = Uri.parse("https://test.com")
      val builtWithEmptyFragment =
        Uri.Builder()
          .scheme("https")
          .authority("test.com")
          .fragment("")
          .build()

      val builtWithNullFragment =
        Uri.Builder()
          .scheme("https")
          .authority("test.com")
          .fragment(null)
          .build()

      assertSoftly {
        fromStrWithEmptyFragment shouldBe builtWithEmptyFragment
        fromStrWithNullFragment shouldBe builtWithNullFragment
      }
    }
  }
}

Thank you!

[eygraber]

I try to follow Android's Uri so if the behavior you're seeing matches that, I would leave it.

Otherwise please feel free to file a PR.

[OptimumCode]

I will check URI implementation in Android, thank you

[OptimumCode]

I have checked the Android sources and it looks like the behavior in Android's URI is the same.
I will report this to the Android team - if they agree that the behaviour should be changed I will create a PR here.
Does this sound good to you, @eygraber?

[OptimumCode]

For reference: https://issuetracker.google.com/issues/346174910

[eygraber]

Absolutely, thank you!