refactor: simplify registry

exuanbo · Nov 19, 2024 · caec65e · caec65e
1 parent 6d890fc
commit caec65e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 35 deletions.
diff --git a/src/container.ts b/src/container.ts
@@ -185,7 +185,7 @@ export function createContainer({
     },
 
     isRegistered(token) {
-      return registry.has(token);
+      return !!registry.get(token);
     },
 
     resetRegistry() {

diff --git a/src/registry.ts b/src/registry.ts
@@ -38,18 +38,7 @@ export class Registry {
   }
 
   get<T>(token: Token<T>): Registration<T> | undefined {
-    return (
-      internals.get(token)
-      || this._get(token)
-    );
-  }
-
-  private _get<T>(token: Token<T>): Registration<T> | undefined {
-    const registrations = this._map.get(token);
-    return (
-      registrations?.at(-1)
-      || this.parent?._get(token)
-    );
+    return this.getAll(token)?.at(-1);
   }
 
   getAll<T>(token: Token<T>): Registration<T>[] | undefined {
@@ -68,35 +57,14 @@ export class Registry {
     );
   }
 
-  has(token: Token): boolean {
-    return (
-      internals.has(token)
-      || this._has(token)
-    );
-  }
-
-  private _has(token: Token): boolean {
-    const registrations = this._map.get(token);
-    return Boolean(
-      registrations?.length
-      || this.parent?._has(token),
-    );
-  }
-
   set<T>(token: Token<T>, registration: Registration<T>): void {
     assert(!internals.has(token), `cannot register reserved token ${token.name}`);
     let registrations = this._map.get(token);
     if (!registrations) {
       registrations = [];
       this._map.set(token, registrations);
     }
-    const existingIndex = registrations.findIndex(({provider}) => provider === registration.provider);
-    if (existingIndex != -1) {
-      registrations[existingIndex] = registration;
-    }
-    else {
-      registrations.push(registration);
-    }
+    registrations.push(registration);
   }
 }