refactor(editor): migrate to latest version of `@codemirror-toolkit/r…

…eact`
exuanbo · Dec 18, 2023 · 9046356 · 9046356
1 parent b741250
commit 9046356
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/features/editor/CodeMirror.tsx b/src/features/editor/CodeMirror.tsx
@@ -11,9 +11,9 @@ const CodeMirror = ({ className }: Props): JSX.Element => {
   const containerRef = useContainerRef()
 
   useViewEffect((view) => {
-    const destructors = viewEffects.map((effect) => effect(view))
-    return () => destructors.forEach((dtor) => dtor?.())
-  }, [])
+    const cleanups = viewEffects.map((effect) => effect(view))
+    return () => cleanups.forEach((cleanup) => cleanup?.())
+  })
 
   return (
     <div

diff --git a/src/features/editor/effects.ts b/src/features/editor/effects.ts
@@ -1,6 +1,6 @@
 import type { Transaction } from '@codemirror/state'
 import { addUpdateListener } from '@codemirror-toolkit/extensions'
-import type { ViewEffectCallback } from '@codemirror-toolkit/react'
+import type { ViewEffectSetup } from '@codemirror-toolkit/react'
 import { mapRangeSetToArray, rangeSetsEqual } from '@codemirror-toolkit/utils'
 import { debounceTime, filter, identity, map, of, switchMap } from 'rxjs'
 
@@ -30,7 +30,7 @@ import {
 import { isTemplate, templateSelection } from './examples'
 import { selectCurrentStatementLinePos } from './selectors'
 
-const defineViewEffect = identity<ViewEffectCallback>
+const defineViewEffect = identity<ViewEffectSetup>
 
 const resetAssemblerStateOnInput = defineViewEffect((view) => {
   const viewUpdate$ = onUpdate(view)
@@ -215,7 +215,7 @@ const toggleVimKeybindings = defineViewEffect((view) => {
   )
 })
 
-export const viewEffects: readonly ViewEffectCallback[] = [
+export const viewEffects: readonly ViewEffectSetup[] = [
   resetAssemblerStateOnInput,
   syncInputToState,
   syncInputFromState,