refactor: remove redundant function wrapping

exuanbo · Dec 10, 2023 · 4035e47 · 4035e47
1 parent 3d8cf65
commit 4035e47
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/app/store/persistence/combinedProvider.ts b/src/app/store/persistence/combinedProvider.ts
@@ -10,7 +10,7 @@ export const getCombinedProvider =
       getQueryParamProvider(validate, fallback),
     ]
     return {
-      read: () => providers.map((provider) => provider.read()).reduce((a, b) => combine(a, b)),
+      read: () => providers.map((provider) => provider.read()).reduce(combine),
       write: (state) => providers.forEach((provider) => provider.write(state)),
     }
   }
diff --git a/src/common/utils/merge.ts b/src/common/utils/merge.ts
@@ -61,9 +61,10 @@ type ExpandDeep<T> = T extends Record<string | number | symbol, unknown>
     ? Array<ExpandDeep<E>>
     : T
 
-export const merge = <Target extends PlainObject, Sources extends PlainObject[]>(
+type Merge = <Target extends PlainObject, Sources extends PlainObject[]>(
   target: Target,
   ...sources: Sources
-): ExpandDeep<O.Assign<Target, Sources, 'deep'>> =>
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  sources.reduce<any>((resultObject, source) => mergeRecursively(resultObject, source), target)
+) => ExpandDeep<O.Assign<Target, Sources, 'deep'>>
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export const merge: Merge = (target, ...sources) => sources.reduce<any>(mergeRecursively, target)