perf(assembler): pre-freeze big object

exuanbo · Dec 14, 2023 · 085caf6 · 085caf6
1 parent 424c380
commit 085caf6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/features/assembler/assemble.ts b/src/features/assembler/assemble.ts
@@ -25,12 +25,12 @@ export const assemble = (input: string): void => {
     store.dispatch(resetMemoryData())
     store.dispatch(clearEditorHighlightRange())
   }
-  const [addressToOpcodeMap, addressToStatementMap] = assembleResult
+  const [addressToCodeMap, addressToStatementMap] = assembleResult
   store.dispatch(setAssemblerState({ source: input, addressToStatementMap }))
-  store.dispatch(setMemoryDataFrom(addressToOpcodeMap))
+  store.dispatch(setMemoryDataFrom(addressToCodeMap))
+  // TODO: move to viewEffects: `store.onAction(setAssemblerState)`
   const firstStatement = addressToStatementMap[0]
-  const hasStatement = firstStatement !== undefined
-  if (hasStatement) {
+  if (firstStatement) {
     store.dispatch(setEditorHighlightRange(firstStatement))
   }
 }
diff --git a/src/features/assembler/assemblerSlice.ts b/src/features/assembler/assemblerSlice.ts
@@ -27,7 +27,7 @@ export const assemblerSlice = createSlice({
     ) => {
       state.error = null
       state.source = action.payload.source
-      state.addressToStatementMap = action.payload.addressToStatementMap
+      state.addressToStatementMap = Object.freeze(action.payload.addressToStatementMap)
     },
     setError: (state, action: PayloadAction<AssemblerErrorObject>) => {
       state.error = action.payload