Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Taken Badge on Report Says "secs" instead of "ms" #194

Closed
bryanh-bloomerang opened this issue Oct 17, 2023 · 3 comments
Closed

Time Taken Badge on Report Says "secs" instead of "ms" #194

bryanh-bloomerang opened this issue Oct 17, 2023 · 3 comments

Comments

@bryanh-bloomerang
Copy link

I've recently started using extent reports and noticed that the time taken badge on a tests is showing "secs". I believe it should say "ms". Given the screenshot below, the start time of this particular test is at 12:39:38 PM and the end time is 12:39:43 PM. The time badge says "5119.81 secs". Given the start and end time and know how long this test generally takes, the value provided is in milliseconds not seconds, so the label should be "ms".

Screenshot 2023-10-17 at 1 41 52 PM
@sudheshg
Copy link
Contributor

@bryanh-bloomerang PR has been raised. #195

@joegardiner
Copy link

It would be good if this would display as ms if below 1s, and seconds above 1s

@anshooarora
Copy link
Member

Closing since PR is now merged.

For the feature request toggling between ms/s, please see #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anshooarora @joegardiner @sudheshg @bryanh-bloomerang