Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add committers to expressjs.com repo #6057

Open
crandmck opened this issue Oct 15, 2024 · 8 comments
Open

Add committers to expressjs.com repo #6057

crandmck opened this issue Oct 15, 2024 · 8 comments

Comments

@crandmck
Copy link
Member

Based on the Contributor Guide, several contributors should be given commit rights to the website repo:

@UlisesGascon
Copy link
Member

+1 from my side. I will update this PR #6033 with the new commiters (tomorrow) 👍

@bjohansebas
Copy link
Member

@UlisesGascon can I open the PR to nominate them? Or do you prefer to update the current PR?

@UlisesGascon
Copy link
Member

Feel free to create a new one with the same format @bjohansebas 👍

@bjohansebas
Copy link
Member

According to what i understood in the meeting, they can be committers without being added to the list.

@wesleytodd
Copy link
Member

Yeah, as long as you all as the captains agree, then no need to add to the list or open an issue here. One thing we should be careful about is that the website doesn't have a release step, any merge is a release. So we should make sure folks are all aligned on the steps needed to land a PR. Maybe even additional branch protections to add "process" to it, but that is all up to you all imo.

@bjohansebas
Copy link
Member

Yep, that's what I was thinking, and maybe it's a good idea to apply a PR policy, like node.js has on its website.

ref: https://github.com/nodejs/nodejs.org/blob/main/CONTRIBUTING.md#pull-request-policy

@bjohansebas
Copy link
Member

This already exists discreetly in the current Express contribution file in general, it might be a good idea to make it more visible and add it to the website's contribution file.

@bjohansebas
Copy link
Member

bjohansebas commented Dec 1, 2024

My PRs will always take longer to merge on the website because they require approval from someone with write permissions to be merged (I'm fine with that and I think it's the best approach), but since only TC members have write permissions, I can't merge my PRs that have already been reviewed by the documentation team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants