Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noun_chunks with "one" as root noun #2043

Closed
thedataist opened this issue Feb 28, 2018 · 3 comments
Closed

noun_chunks with "one" as root noun #2043

thedataist opened this issue Feb 28, 2018 · 3 comments
Labels
help wanted Contributions welcome! lang / en English language data and models perf / accuracy Performance: accuracy

Comments

@thedataist
Copy link

thedataist commented Feb 28, 2018

For sentences containing noun phrases where the root noun is "one", e.g. "I want the really expensive one", doc.noun_chunks does not currently return the noun chunk containing "one". This is probably an issue with the english models, as "one" is returned tagged as CD/NUM (cardinal number) and it should likely be NN/NOUN in this case (slightly ambiguous), but could also be handled with a special case in the syntax_iterators noun_chunks code where "one" (or any cardinal number) is allowed to appear in the root noun slot.

  • spaCy version: 2.0.9
  • Platform: Darwin-17.4.0-x86_64-i386-64bit
  • Python version: 3.6.1
  • Models: en_core_web_md, en
@meshiguge

This comment has been minimized.

@ines ines added help wanted Contributions welcome! lang / en English language data and models labels May 21, 2018
@ines ines added perf / accuracy Performance: accuracy and removed performance labels Aug 15, 2018
@ines
Copy link
Member

ines commented Dec 14, 2018

The noun chunks depend on the part-of-speech tags and dependency parse, so yes, this issue likely comes down to incorrect predictions made by the tagger or parser.

I'm merging this with #3052. We've now added a master thread for incorrect predictions and related reports – see the issue for more details.

@ines ines closed this as completed Dec 14, 2018
@lock
Copy link

lock bot commented Jan 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Contributions welcome! lang / en English language data and models perf / accuracy Performance: accuracy
Projects
None yet
Development

No branches or pull requests

4 participants