Skip to content

Conversation

@cmcaine
Copy link
Contributor

@cmcaine cmcaine commented May 23, 2022

This regresses on the status quo on error messages because they end up with "Expr(:escape" and crap like that in them, and the line numbers of the errors are messed up too. There are probably ways to fix that.

PR looks big because it's based on #77 and #78. It's actually just one commit.

@cmcaine cmcaine force-pushed the capture-output-per-test branch from e5a5d71 to 4ade5e3 Compare May 23, 2022 09:51
@cmcaine cmcaine mentioned this pull request May 23, 2022
@cmcaine cmcaine force-pushed the capture-output-per-test branch from 1b7eb9a to 4413802 Compare June 7, 2022 14:06
@cmcaine
Copy link
Contributor Author

cmcaine commented Jun 7, 2022

To do:

  • Remove the macros from the stacktrace (Test has a function for this)
  • Maybe store the extra data on the testset rather than in a module-global Dict
  • Define macros for test_skip, _broken, _logs
  • Maybe pull the ReportingTestSet stuff out into its own package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants