Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Analyzer extension for concept exercise: basic-slices #25

Open
tehsphinx opened this issue Jan 25, 2020 · 3 comments
Open

[V3] Analyzer extension for concept exercise: basic-slices #25

tehsphinx opened this issue Jan 25, 2020 · 3 comments

Comments

@tehsphinx
Copy link
Member

This issue describes what the Go analyzer should check for in the card-tricks exercise.

Function GetItem

  • no else should be used
  • early return should be used which makes a total sum of 2 return statements.
  • there needs to be exactly one if statement (with 2 conditions)
  • no switch should be used

Function SetItem

  • all 4 checks of GetItem apply here as well

Function PrefilledSlice

  • check instantiation of the slice. It should be created with a len or cap given
  • check for a for loop (no range, not recursive)

Function NumberRow

  • check instantiation of the slice. No make or new should be used but a nil slice created with var xy []int
  • optional: check if for loop increases index (for i := 1; true; i++)

Function RemoveItemPure

  • all 4 checks of GetItem apply here as well
  • shouldn't use a for loop, only append

Function RemoveItem

  • all 4 checks of GetItem apply here as well
@tehsphinx tehsphinx assigned tehsphinx and unassigned tehsphinx Jan 29, 2020
@jamessouth

This comment has been minimized.

@oanaOM

This comment has been minimized.

@BethanyG BethanyG changed the title [Go] Analyzer extension for concept exercise: basic-slices [V3] Analyzer extension for concept exercise: basic-slices Jan 28, 2021
@BethanyG BethanyG transferred this issue from exercism/v3 Jan 28, 2021
@junedev
Copy link
Member

junedev commented Oct 22, 2021

Please note, the description does not yet reflect the latest version of the exercise.

@junedev junedev transferred this issue from exercism/go Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants