Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend the return type of function in raindrop #969

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Amend the return type of function in raindrop #969

merged 1 commit into from
Apr 4, 2024

Conversation

Ashvith10
Copy link
Contributor

Return type is amended from char* to void for the function convert(char result[], int drops)

Fixes #968

wolf99
wolf99 requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@wolf99 wolf99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for this file, but changes will be needed in the header and source in the exercise's .meta directory also.

@Ashvith10
Copy link
Contributor Author

@wolf99 my bad. Looks like there's a whole lot of stuff to change - but since the ls command in my GuixSD instance wasn't configured with hidden files, I missed out on that. I'll be pushing out the new changes soon.

@Ashvith10 Ashvith10 force-pushed the amend-raindrop-function-return-type branch from 6d6d48b to 79cc915 Compare April 4, 2024 07:23
@Ashvith10
Copy link
Contributor Author

I tried checking out for all instances of incorrect definitions using grep -nr "char *convert(.*)". Hopefully, that should check for all the strings in the directory recursively.

@Ashvith10 Ashvith10 force-pushed the amend-raindrop-function-return-type branch from 79cc915 to f65ef2a Compare April 4, 2024 10:09
@Ashvith10 Ashvith10 force-pushed the amend-raindrop-function-return-type branch from f65ef2a to 60d8f57 Compare April 4, 2024 10:23
wolf99
wolf99 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@wolf99 wolf99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge!
Thank you @Ashvith10 !

@wolf99 wolf99 merged commit e6a8b2c into exercism:main Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanplusplus ryanplusplus ryanplusplus approved these changes

@wolf99 wolf99 wolf99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type for convert(char result[], int drops) in "Raindrop" should be of type void
3 participants
@Ashvith10 @wolf99 @ryanplusplus