Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Firebase calls into shared services #90

Open
bjsawyer opened this issue Jun 29, 2017 · 0 comments
Open

Refactor Firebase calls into shared services #90

bjsawyer opened this issue Jun 29, 2017 · 0 comments
Assignees

Comments

@bjsawyer
Copy link
Contributor

There are lots of GET/PUT/POST calls to Firebase within our components that should really be pulled into services instead. We should be able to parameterize these functions to reduce all the duplicated logic and make things cleaner.

  • Create service for each db table
  • Inject AngularFire2 into services via constructor and remove from components
  • Inject new services into components instead
  • Create functions that call Firebase
    • GET
    • PUT
    • POST
    • DELETE
    • Object vs. List versions of each (?)
  • TODO: Create issues to unit test these services

Question: Stick to subscriptions, or use async/await?

@bjsawyer bjsawyer self-assigned this Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant