Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create npm package #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Create npm package #38

wants to merge 1 commit into from

Conversation

lipis
Copy link
Member

@lipis lipis commented Mar 3, 2021

No description provided.

@vercel
Copy link

vercel bot commented Mar 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/virgil/3BEw8F6VyFuwzNqScTyAaL3YDMe3
✅ Preview: https://virgil-git-package-excalidraw.vercel.app

"files": [
"Virgil.woff2",
"LICENSE.md"
],
"license": "OFL-1.1",
"name": "virgil",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is taken. https://www.npmjs.com/package/virgil
We should go with @excalidraw/virgil, I guess?

@thorn0
Copy link
Collaborator

thorn0 commented Mar 3, 2021

An interesting question is versioning. Can a font use semver? What changes will be considered breaking? Looks like the version is forever going to be 1.0.x.

@thorn0 thorn0 linked an issue Mar 3, 2021 that may be closed by this pull request
@dwelle
Copy link
Member

dwelle commented Mar 3, 2021

The name is taken. npmjs.com/package/virgil
We should go with @excalidraw/virgil, I guess?

Yes, since all the changes we do to it are our own (i.e., they're subjective fixes tailored for our use case), it makes sense.

An interesting question is versioning. Can a font use semver? What changes will be considered breaking? Looks like the version is forever going to be 1.0.x.

I'd actually start at 0.x.x before we feel the font is in a solid enough shape for a 1.0.0. After that, I'd consider kerning changes as breaking, since it'll change width of the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it an npm package
3 participants