Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the testing suite for FuncX #67

Open
WardLT opened this issue Aug 17, 2022 · 0 comments
Open

Improve the testing suite for FuncX #67

WardLT opened this issue Aug 17, 2022 · 0 comments

Comments

@WardLT
Copy link
Collaborator

WardLT commented Aug 17, 2022

The FuncXExecutor has some behavior around threads we don't mock, but that caused the FuncXTaskServer to break when FuncX updated to v1. We should make our mock executor wrap the FuncXExecutor (and, perhaps, mark the futures as complete once _batch_run returns them) so that we ensure that Colmena is properly tested against FuncX

See e5dbc04 for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant