✅ server: verify locale-aware push notification content

Author: aguxez

server/test/hooks/manteca.test.ts

@@ -173,6 +173,7 @@ describe("manteca hook", () => {
   describe("when a deposit is detected", () => {
     it("converts to USDC", async () => {
       vi.spyOn(manteca, "convertBalanceToUsdc").mockResolvedValue();
+      const sendPushNotification = vi.spyOn(onesignal, "sendPushNotification");
       const payload = {
         event: "DEPOSIT_DETECTED",
         data: {
@@ -193,6 +194,11 @@ describe("manteca hook", () => {
       expect(response.status).toBe(200);
       await expect(response.json()).resolves.toStrictEqual({ code: "ok" });
       expect(manteca.convertBalanceToUsdc).toHaveBeenCalledWith("456", "ARS");
+      expect(sendPushNotification).toHaveBeenCalledWith({
+        userId: account,
+        headings: { en: "Deposited funds", es: "Fondos depositados" }, // cspell:ignore Fondos depositados
+        contents: { en: "1,000 ARS deposited", es: "1.000 ARS depositados" }, // cspell:ignore depositados
+      });
     });
 
     it("returns ok if credential does not exist", async () => {

server/test/hooks/panda.test.ts

@@ -47,6 +47,7 @@ import { proposalManager } from "@exactly/plugin/deploy.json";
 import database, { cards, credentials, transactions } from "../../database";
 import app from "../../hooks/panda";
 import keeper from "../../utils/keeper";
+import * as onesignal from "../../utils/onesignal";
 import * as panda from "../../utils/panda";
 import publicClient from "../../utils/publicClient";
 import * as sardine from "../../utils/sardine";
@@ -601,6 +602,44 @@ describe("card operations", () => {
         expect(response.status).toBe(200);
       });
 
+      it("sends locale-aware card purchase notification", async () => {
+        const sendPushNotificationSpy = vi
+          .spyOn(onesignal, "sendPushNotification")
+          .mockImplementation(() => Promise.resolve(undefined as never));
+        // @ts-expect-error mock implementation
+        vi.spyOn(keeper, "exaSend").mockImplementation(async (...args) => {
+          await args[2]?.onHash?.(zeroHash as Hash);
+        });
+        const localAmount = 123_456;
+        const cardId = "locale-notify";
+        await database.insert(cards).values([{ id: cardId, credentialId: "cred", lastFour: "9999", mode: 0 }]);
+
+        const response = await appClient.index.$post({
+          ...authorization,
+          json: {
+            ...authorization.json,
+            action: "created",
+            body: {
+              ...authorization.json.body,
+              id: cardId,
+              spend: { ...authorization.json.body.spend, cardId, localAmount, localCurrency: "ars" },
+            },
+          },
+        });
+
+        expect(response.status).toBe(200);
+        await vi.waitFor(() => expect(sendPushNotificationSpy).toHaveBeenCalled());
+        const call = sendPushNotificationSpy.mock.calls[0]?.[0];
+        expect(call?.headings).toStrictEqual({ en: "Card purchase", es: "Compra con tarjeta" }); // cspell:ignore Compra tarjeta
+        const enAmount = (localAmount / 100).toLocaleString("en-US", { style: "currency", currency: "ars" });
+        const esAmount = (localAmount / 100).toLocaleString("es-AR", { style: "currency", currency: "ars" });
+        expect(enAmount).not.toBe(esAmount);
+        expect(call?.contents).toStrictEqual({
+          en: `${enAmount} at 99999. Paid with USDC`,
+          es: `${esAmount} en 99999. Pagado con USDC`, // cspell:ignore Pagado
+        });
+      });
+
       it("fails with transaction timeout", async () => {
         const error = new Error("timeout");
         const track = vi.spyOn(segment, "track").mockReturnValue();
@@ -896,6 +935,7 @@ describe("card operations", () => {
       afterEach(() => vi.restoreAllMocks());
 
       it("handles reversal", async () => {
+        const sendPushNotification = vi.spyOn(onesignal, "sendPushNotification");
         const amount = 2073;
         const cardId = "card";
         await keeper.exaSend(
@@ -954,6 +994,14 @@ describe("card operations", () => {
 
         expect(deposit?.args.assets).toBe(BigInt(amount * 1e4));
         expect(response.status).toBe(200);
+        expect(sendPushNotification).toHaveBeenCalledWith({
+          userId: account,
+          headings: { en: "Refund processed", es: "Reembolso procesado" }, // cspell:ignore Reembolso procesado
+          contents: {
+            en: "20.73 USDC from 99999 have been refunded to your account",
+            es: "20,73 USDC de 99999 fueron reembolsados a tu cuenta", // cspell:ignore reembolsados cuenta fueron
+          },
+        });
       });
 
       it("returns ok on reversal replay", async () => {

server/test/i18n.test.ts

@@ -0,0 +1,81 @@
+import { describe, expect, it } from "vitest";
+
+import t, { formatAmount } from "../i18n";
+
+describe("formatAmount()", () => {
+  describe("number input", () => {
+    it("preserves sub-micro values", () => {
+      expect(formatAmount(0.000_000_9)).toStrictEqual({ en: "0.0000009", es: "0,0000009" });
+    });
+
+    it("preserves 6 fractional digits", () => {
+      expect(formatAmount(0.000_001)).toStrictEqual({ en: "0.000001", es: "0,000001" });
+    });
+
+    it("formats regular decimals", () => {
+      expect(formatAmount(99.973)).toStrictEqual({ en: "99.973", es: "99,973" });
+    });
+
+    it("formats integers", () => {
+      expect(formatAmount(5)).toStrictEqual({ en: "5", es: "5" });
+    });
+
+    it("formats thousands with separator", () => {
+      expect(formatAmount(1000)).toStrictEqual({ en: "1,000", es: "1.000" });
+    });
+  });
+
+  describe("string input", () => {
+    it("formats regular decimals", () => {
+      expect(formatAmount("99.973")).toStrictEqual({ en: "99.973", es: "99,973" });
+    });
+
+    it("preserves sub-micro values and trims trailing zeros", () => {
+      expect(formatAmount("0.00000090")).toStrictEqual({ en: "0.0000009", es: "0,0000009" });
+    });
+
+    it("formats integers", () => {
+      expect(formatAmount("5")).toStrictEqual({ en: "5", es: "5" });
+    });
+  });
+});
+
+describe("t()", () => {
+  it("returns en and es translations with no options", () => {
+    const result = t("Card purchase");
+    expect(result).toStrictEqual({ en: "Card purchase", es: "Compra con tarjeta" }); // cspell:ignore Compra tarjeta
+  });
+
+  it("interpolates plain string values into both languages", () => {
+    const result = t("{{localAmount}} at {{merchantName}}. Paid with USDC", {
+      localAmount: "$1,234.56",
+      merchantName: "Store",
+    });
+    expect(result).toStrictEqual({
+      en: "$1,234.56 at Store. Paid with USDC",
+      es: "$1,234.56 en Store. Pagado con USDC", // cspell:ignore Pagado
+    });
+  });
+
+  it("resolves per-language objects in interpolation values", () => {
+    const result = t("{{localAmount}} at {{merchantName}}. Paid with USDC", {
+      localAmount: { en: "$1,234.56", es: "$ 1.234,56" },
+      merchantName: "Store",
+    });
+    expect(result).toStrictEqual({
+      en: "$1,234.56 at Store. Paid with USDC",
+      es: "$ 1.234,56 en Store. Pagado con USDC", // cspell:ignore Pagado
+    });
+  });
+
+  it("mixes per-language and plain values", () => {
+    const result = t("{{localAmount}} at {{merchantName}}. Paid with credit", {
+      localAmount: { en: "A", es: "B" },
+      merchantName: "Store",
+    });
+    expect(result).toStrictEqual({
+      en: "A at Store. Paid with credit",
+      es: "B en Store. Pagado con crédito", // cspell:ignore Pagado crédito
+    });
+  });
+});