Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancies between API interface StageItemWithRounds and frontend's StageItemWithRounds #816

Open
robigan opened this issue Jul 14, 2024 · 1 comment

Comments

@robigan
Copy link
Contributor

robigan commented Jul 14, 2024

The frontend defines StageItemWithRounds as

export interface StageItemWithRounds {
id: number;
tournament_id: number;
created: string;
type: string;
name: string;
type_name: string;
team_count: number;
is_active: boolean;
rounds: RoundInterface[];
inputs: StageItemInput[];
}

but the API defines it as
image

Note the discrepancies in fields ournament_id/stage_id and the additional field is_active. Is this correct? As I see that in

[activeStage] = getStageById(swrStagesResponse, stageItem.stage_id);

stage_id is utilized, but TypeScript complains that this property doesn't exist on the interface defined. So I'm opening this issue to confirm you meant stage_id and not tournament_id.

@robigan
Copy link
Contributor Author

robigan commented Jul 16, 2024

this bug would be addressed in #530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant