Fixes evidentlyai/evidently#1030 negative values on axes #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for negative values
|
Current state After Fix |
|
Please merge latest commits from main to fix pip-audit 🤗 |
emeli-dral
requested review from
DimaAmega and
mike0sv
and removed request for
mike0sv
|
Hi @GwenVCX Thanks a lot for this PR! This made me pay more attention to this known issue, and, in fact, I found a more appropriate solution to fix this problem. So, please, merge this PR in your evidently fork :) I also added a few comments in PR in order to explain solution, but basically, we just need to set utf-8 charset in the resulting html file |
DimaAmega
requested changes
Jul 15, 2024
Fix charset in inline html file
DimaAmega
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030 Weird labelling for y-axis in some error plots for negative values