Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Height prop is not respected for AreaMap or BoxPlot #3046

Open
archiewood opened this issue Jan 27, 2025 · 3 comments · May be fixed by #3102
Open

[Bug]: Height prop is not respected for AreaMap or BoxPlot #3046

archiewood opened this issue Jan 27, 2025 · 3 comments · May be fixed by #3102
Labels
bug Something isn't working

Comments

@archiewood
Copy link
Member

archiewood commented Jan 27, 2025 •
edited
Loading

Describe the bug

height prop does not impact height of AreaMap component

Steps to Reproduce

Using docs site

<AreaMap 
            data={la_zip_sales} 
            areaCol=zip_code
            geoJsonUrl='/geo-json/ca_california_zip_codes_geo_1.min.json'
            geoId=ZCTA5CE10
            value=sales
            height=500
/>

should adjust the height to 500px, but it does not

Severity

annoyance
@archiewood archiewood added bug Something isn't working to-review Evidence team to review and removed to-review Evidence team to review labels Jan 27, 2025
@archiewood archiewood changed the title [Bug]: Height prop is not respected for AreaMap [Bug]: Height prop is not respected for AreaMap or BoxPlot Feb 7, 2025
@archiewood
Copy link
Member Author

Adding, boxplot has same issue

@timothyhoward
Copy link

Hey @archiewood, just letting you know it's affecting the PointMap component as well.

@pax
Copy link

pax commented Feb 14, 2025

Seems like it gets its value from BaseMap.svelte instead of AreaMap (or any OtherMap)

I managed to change the default value by changing the default value for BaseMap.svelte in /node_modules/@evidence-dev/core-components/dist/unsorted/viz/map/
look for export let height = 300; // height in pixels
Changing same line for AreaMap.svelte doesn't help.

After changing the values run npm run install before launching.

@archiewood archiewood linked a pull request Feb 14, 2025 that will close this issue
Open
4 tasks
@archiewood archiewood linked a pull request Feb 14, 2025 that will close this issue
Component height prop fix #3102
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Component height prop fix evidence-dev/evidence
3 participants
@pax @timothyhoward @archiewood