Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR End to end tests #3093

Open
ItsMeBrianD opened this issue Feb 12, 2025 · 0 comments
Open

HMR End to end tests #3093

ItsMeBrianD opened this issue Feb 12, 2025 · 0 comments

Comments

@ItsMeBrianD
Copy link
Contributor

In #3041 a few HMR tests were removed because of a Vite oddity causing full page reloads.

If a page has been visited previously, then changes made to it are eligible for HMR - however if a page has not been visited since the dev server started, then changes will cause a full page reload.

The tests for adding / removing pages were inaccurate because of this ( the test run shares a single dev server ), and full page reloads were occurring when running the tests in isolation. Because this is a minor DX issue, we've opted to remove those tests until more time can be allocated to fixing this behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant