Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring by an arbitrary cell metadata column (enhancement) #9

Open
VPetukhov opened this issue May 9, 2023 · 4 comments
Open

Coloring by an arbitrary cell metadata column (enhancement) #9

VPetukhov opened this issue May 9, 2023 · 4 comments

Comments

@VPetukhov
Copy link

To my understanding, currently there is no way to color the dataset by anything but cluster id. Having a color column selector would add a lot to usability. For example, adding a drop-down to the left of "Change Color Palette". Seems like a very easy fix. Do you plan adding such functionality? If it would help, I can submit a PR for that.

@euxhenh
Copy link
Owner

euxhenh commented May 9, 2023

I agree that this would be useful. Were you thinking of allowing all keys in adata.obs to be selected? How would we handle columns with too many categorical values? From my experience, this can slow down plot generation a lot.

@VPetukhov
Copy link
Author

Thank you for the quick reply! Yes, I meant all variables from adata.obs. IMO, it's fine to leave on the user-side: if they're willing to wait, that's alright. But if you prefer, a hard limit of 30-50 values can be used.

@euxhenh
Copy link
Owner

euxhenh commented May 12, 2023

Sounds good! I will work on this. Adding it to the plot's header sounds right.

@VPetukhov
Copy link
Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants