Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For anyone who wants to keep using this repo in vue3 project. #814

Open
imndx opened this issue Feb 28, 2024 · 6 comments
Open

For anyone who wants to keep using this repo in vue3 project. #814

imndx opened this issue Feb 28, 2024 · 6 comments

Comments

@imndx
Copy link

imndx commented Feb 28, 2024

The following is all you need to use this plugin in your vue3 project, especially for those project migrated from vue2.

  1. clone this repo
  2. apply the attached patch
  3. copy the source code to your project
  4. npm install --save resize-observer-polyfill
  5. npm uninstall vue-js-modal
  6. import your local vue-js-modal instead of the original 'vue-js-modal'
  7. none

vue3.patch

@pzpsofficial
Copy link

Hi @imndx, which node version did you use to build the project with patched code?

@pzpsofficial
Copy link

Also the patched code uses createVNode function, which was replaced by h in Vue 3. What am I missing?

@wloszynski
Copy link

bump

@imndx
Copy link
Author

imndx commented May 22, 2024

Hi @imndx, which node version did you use to build the project with patched code?

18.9.0

kalnado added a commit to mendo/vue-js-modal that referenced this issue May 28, 2024
@Aliozzaim
Copy link

If you’re still having issues adapting this modal to Vue 3, please take a look at this article: Fixing vue-js-modal for Vue 3: A Guide to Restoring Modal Functionality.

@rangermeier
Copy link

If you’re still having issues adapting this modal to Vue 3, please take a look at this article: Fixing vue-js-modal for Vue 3: A Guide to Restoring Modal Functionality.

Thanks for the write-up. It would be awesome if you could publish a fork on Github with the changes detailed in your article!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants