Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch to zoom not centred when embedded #118

Open
wahlatlas opened this issue Oct 29, 2023 · 2 comments
Open

Pinch to zoom not centred when embedded #118

wahlatlas opened this issue Oct 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@wahlatlas
Copy link

wahlatlas commented Oct 29, 2023

Check these examples:

Pinch to zoom on a GridViz instance that takes the whole window works like expected, e.g. this one, where the zoom center roughly stays the same
https://eurostat.github.io/gridviz/examples/DE.html

Pinch to zoom in an embedded view (Observable or other) zooms the map but also moves the map in a north-eastern direction so that the detail you wanted to zoom in moves out of the viewport, e.g. in this example
https://observablehq.com/d/3d1d998ba43e1f69

See video here for detail on an iPad pro (iOS 17.1)
https://wahlatlas.net/experimente/testcases/gridviz_pinch_zoom_issue118.mp4

in the video the issue may look subtle, but there are cases, smaller embed, more removed from window edges, where this makes zooming on touch devices a two part action: first zoom, then drag backwards to the original position

@jgaffuri
Copy link
Contributor

jgaffuri commented Nov 5, 2023

Indeed !
I will have a look. In general, we should make more tests on non-full screen examples for this kind of feature.

@jgaffuri jgaffuri self-assigned this Nov 5, 2023
@joewdavies joewdavies self-assigned this Nov 9, 2023
@joewdavies joewdavies added the bug Something isn't working label Dec 2, 2024
@joewdavies
Copy link
Collaborator

I believe I may have fixed this: https://eurostat.github.io/gridviz/examples/test/embed/observable.html
As of version 3.0.18
Please check and let us know!
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants