Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more data as REST-API in JSON format 👨‍💻✨🎫 #2

Open
euhidaman opened this issue Oct 5, 2021 · 10 comments
Open

Adding more data as REST-API in JSON format 👨‍💻✨🎫 #2

euhidaman opened this issue Oct 5, 2021 · 10 comments
Labels
good first issue Good for newcomers hacktoberfest Accepted for hacktoberfest hacktoberfest-accepted Accepted for hacktoberfest event

Comments

@euhidaman
Copy link
Owner

euhidaman commented Oct 5, 2021

Add a new REST-API JSON file, and create a pull request.

Also, make sure to Star this repository. So that, It can reach to a wider audience, and more people can contribute to it !!

@euhidaman euhidaman added good first issue Good for newcomers hacktoberfest-accepted Accepted for hacktoberfest event hacktoberfest Accepted for hacktoberfest labels Oct 5, 2021
@euhidaman euhidaman pinned this issue Oct 5, 2021
@euhidaman euhidaman changed the title Adding more data as REST-API in JSON format Adding more data as REST-API in JSON format 👨‍💻✨🎫 Oct 5, 2021
@legion20
Copy link
Contributor

legion20 commented Oct 5, 2021

Hey, I am new to open source and as this is a good first issue. I would like to work on it, but just a small doubt, can u explain what exactly we have to do or suggest me some references for it?

@euhidaman
Copy link
Owner Author

So, in simple terms, you must work and contribute in the following steps :

  1. Fork the repo and clone it on your local machine.
  2. Create a branch, where you must do your own contributions.
  3. Create a new JSON file with your custom name, and with your chosen data.
    The file, should be like this : sharksinfo.json
  4. Then stage and commit your changes.
  5. Finally, create a pull request, so that I can merge it with this project repository.

Note : To know, how to Fork, Clone, Create a branch and Creating a pull request, you can view this 5 minute video : https://www.youtube.com/watch?v=rgbCcBNZcdQ

@legion20
Copy link
Contributor

legion20 commented Oct 5, 2021

Ok. Got it. So, basically I have to create a JSON file with my preferred dataset. If I am right, can u assign me this issue?

@euhidaman
Copy link
Owner Author

No need of assigning. Interested people can directly create a pull request.

@mephi007
Copy link
Contributor

mephi007 commented Oct 6, 2021

Hi @euhidaman, I have raised a pull request to add top 5 basket ball players #6. Please review.

@rehanpunjwani
Copy link
Contributor

hi @euhidaman, I have raised a pull request to add countries data #11. Please review. 🚀

@sonalsingh25
Copy link
Contributor

Hi, @euhidaman please review #12 and let me know if any changes are required.

@rahulxsingh
Copy link
Contributor

@euhidaman Can you please check if #14 looks good to you?

@mephi007
Copy link
Contributor

Hi @euhidaman, I have raised Pr #27 to add basket Ball teams. Please review and merge

@Rosy03
Copy link
Contributor

Rosy03 commented Oct 24, 2021

Hello @euhidaman , I have raised PR as following:
Create Indian-Sweets.json #31
Please review and accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Accepted for hacktoberfest hacktoberfest-accepted Accepted for hacktoberfest event
Projects
None yet
Development

No branches or pull requests

7 participants