Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate function properties #257

Open
clabe45 opened this issue Feb 18, 2024 · 0 comments
Open

Deprecate function properties #257

clabe45 opened this issue Feb 18, 2024 · 0 comments
Labels
priority:medium type:feature New feature or request

Comments

@clabe45
Copy link
Collaborator

clabe45 commented Feb 18, 2024

Dynamic properties set to functions are unnecessary. The logic used to calculate function properties can easily be moved to JavaScript getters. Alternatively, these properties can be set to different constant values each frame (e.g., in Layer.render() or Effect.apply()). An onDraw option will later be added to Movie.play() (#230), Movie.stream() (#231) and Movie.record() (#232). The effort of maintaining this type of dynamic property is not worth it, since there is no value-add. In fact, providing many different ways to calculate a property with some custom logic can result in antipatterns and technical debt.

@clabe45 clabe45 added type:feature New feature or request priority:medium labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant