[proposed] Update BytecodeObject validation requirements #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define separate `UnlinkedBytecodeObject` and `LinkedBytecodeObject` - Use those respectively for `ContractType` and `ContractInstance` - Ensure unlinked bytecode always requires `link_references` - Update examples to specify `[]` for bytecode that doesn't link
Because the inheritance makes some tools not work right
njgheorghita
approved these changes
Aug 23, 2018
|
Thanks @njgheorghita! If you want to take a stab at the docs, be my guest. I won't have time before tomorrow to get to it, unfortunately. Or just feel free to tell me it's my responsibility :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #123.
This contains only the formal spec changes. Will need to rewrite the natural language spec if this is change has support.