Merge pull request #97 from 0xProject/fake-tx-include-signature-by-de…

…fault Include signature by default in FakeTransaction.hash
ethereumjs · Jun 22, 2018 · 9d2302d · 9d2302d
2 parents a73cc66 + 29d1153
commit 9d2302d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/fake.js b/fake.js
@@ -58,7 +58,7 @@ module.exports = class FakeTransaction extends Transaction {
    * @param {Boolean} [includeSignature=true] whether or not to inculde the signature
    * @return {Buffer}
    */
-  hash (includeSignature) {
+  hash (includeSignature = true) {
     if (includeSignature) {
       // include a fake signature using the from address as a private key
       let fakeKey = Buffer.concat([this._from, this._from.slice(0, 12)])

diff --git a/test/fake.js b/test/fake.js
@@ -16,8 +16,8 @@ tape('[FakeTransaction]: Basic functions', function (t) {
     var modifiedFromFieldTxData = Object.assign({}, baseTxData, { from: '0x2222222222222222222222222222222222222222' })
     var baseTx = new FakeTransaction(baseTxData)
     var modifiedFromFieldTx = new FakeTransaction(modifiedFromFieldTxData)
-    var baseTxHash = utils.bufferToHex(baseTx.hash(true))
-    var modifiedFromFieldTxHash = utils.bufferToHex(modifiedFromFieldTx.hash(true))
+    var baseTxHash = utils.bufferToHex(baseTx.hash())
+    var modifiedFromFieldTxHash = utils.bufferToHex(modifiedFromFieldTx.hash())
     st.notEqual(baseTxHash, modifiedFromFieldTxHash, 'FakeTransactions with different `from` addresses but otherwise identical data should have different hashes')
   })
 })