Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwise ghost implementation - clear winner tie #100

Open
AgeManning opened this issue Mar 1, 2019 · 0 comments
Open

Bitwise ghost implementation - clear winner tie #100

AgeManning opened this issue Mar 1, 2019 · 0 comments

Comments

@AgeManning
Copy link

This issue refers to the bitwise LMD Ghost implementation:
https://github.com/ethereum/research/blob/master/ghost/ghost.py

In the event a chain has two children of equal weight and the log lookup is successful, the implementation calls get_clear_winner(). This will choose a winner based on the ordering of the python dictionary (in contrast to the bitwise selection which breaks ties based on lowest hash of the block). See line:

if v >= total_vote_count // 2:

Should this perhaps be > rather than >= as it seems that a clear winner is not obvious for equally weighted children.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant