EIP170 Contract Size Limit

[fubuloubu]

What is wrong?

Double checking this is the intended functionality.

EIP170 states that the contract size limit was changed to 2**14 + 2**13 which is 24,576 bytes. The following line implementations the constant for EIP170, but it is off by one.

py-evm/eth/vm/forks/spurious_dragon/constants.py

Line 13 in 0ff7bc0

EIP170_CODE_SIZE_LIMIT = 24577

How can it be fixed

Validate that the number is correctly applied. If it is, consider making the number match and modifying the condition that tests for it so that it works with the actual number described in EIP170.

[carver]

Validate that the number is correctly applied.

Yup a quick search shows that it is functioning correctly.

py-evm/eth/vm/forks/spurious_dragon/computation.py

Line 41 in ae1e3e4

if contract_code and len(contract_code) >= EIP170_CODE_SIZE_LIMIT:

---

consider making the number match and modifying the condition that tests for it

The change seems fine to me, I agree that it's at least a slight improvement.

[pipermerriam]

Might be good for us to write a non-JSON-fixture based test to test for this specific thing. We rely on the JSON-fixture tests for compliance with these things, but it'd be good to have a legible test as well (similar to what @cburgdorf has done for many of our opcodes).

[glaksmono]

Would like to take a stab on this

[pipermerriam]

@glaksmono 👍

[dherykw]

@pipermerriam , is the issue solved with the #1799 pull request?

[e3243eric]

I dug into this issue. I have some thoughts about this. Please let me know if there are any mistakes.

• opcodes for deploy contract are the "init code". It copies/stores the contract code in memory and should return the memory address at the end.

• The condition of this line should be '>' when the EIP170_CODE_SIZE_LIMIT is 24576.
  

  py-evm/eth/vm/forks/spurious_dragon/computation.py

  Line 86 in 12f3bee

  if len(contract_code) >= EIP170_CODE_SIZE_LIMIT:

[kclowes]

Completed via #2083