Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpconfig produces invalid NAT toml #31183

Closed
corverroos opened this issue Feb 14, 2025 · 0 comments · Fixed by #31192
Closed

dumpconfig produces invalid NAT toml #31183

corverroos opened this issue Feb 14, 2025 · 0 comments · Fixed by #31192
Assignees
Labels

Comments

@corverroos
Copy link

System information

Geth version: v1.15.1

Expected behaviour

v1.15.0 added support to configuring Node.P2P.NAT in config.toml.

Given a config.toml with a NAT value configured, one expects that geth dumpconfig would produce valid toml with the same NAT configured.

Actual behaviour

It produces invalid toml that cannot be used a config.

Steps to reproduce the behaviour

config.toml:

[Node.P2P]
NAT = "extip:1.2.3.4"

Run dumpconfig:

docker run --volume=./config.toml:/tmp/config.toml ethereum/client-go:v1.15.1 dumpconfig --config=/tmp/config.toml

Produces invalid toml that contains:


[Node.P2P.NAT]
Interface = "extip:1.2.3.4"

Note that running dumpconfig with legacy --nat=expip:1.2.3.4 cli flag the output is correct.

@fjl fjl self-assigned this Feb 14, 2025
fjl added a commit that referenced this issue Feb 17, 2025
This fixes an issue where a nat.Interface unmarshaled from the TOML
config file could not be re-marshaled to TOML correctly.

Fixes #31183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants