We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geth version: v1.15.1
v1.15.1
v1.15.0 added support to configuring Node.P2P.NAT in config.toml.
Node.P2P.NAT
config.toml
Given a config.toml with a NAT value configured, one expects that geth dumpconfig would produce valid toml with the same NAT configured.
geth dumpconfig
It produces invalid toml that cannot be used a config.
config.toml:
[Node.P2P] NAT = "extip:1.2.3.4"
Run dumpconfig:
docker run --volume=./config.toml:/tmp/config.toml ethereum/client-go:v1.15.1 dumpconfig --config=/tmp/config.toml
Produces invalid toml that contains:
[Node.P2P.NAT] Interface = "extip:1.2.3.4"
Note that running dumpconfig with legacy --nat=expip:1.2.3.4 cli flag the output is correct.
--nat=expip:1.2.3.4
The text was updated successfully, but these errors were encountered:
p2p: fix marshaling of NAT in TOML (#31192)
c113e3b
This fixes an issue where a nat.Interface unmarshaled from the TOML config file could not be re-marshaled to TOML correctly. Fixes #31183
fjl
Successfully merging a pull request may close this issue.
System information
Geth version:
v1.15.1
Expected behaviour
v1.15.0 added support to configuring
Node.P2P.NAT
inconfig.toml
.Given a
config.toml
with a NAT value configured, one expects thatgeth dumpconfig
would produce valid toml with the same NAT configured.Actual behaviour
It produces invalid toml that cannot be used a config.
Steps to reproduce the behaviour
config.toml:
Run dumpconfig:
Produces invalid toml that contains:
Note that running dumpconfig with legacy
--nat=expip:1.2.3.4
cli flag the output is correct.The text was updated successfully, but these errors were encountered: