Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support discv5 call which don't need response #31112

Open
Tracked by #31092
GrapeBaBa opened this issue Feb 2, 2025 · 2 comments · May be fixed by #31150
Open
Tracked by #31092

Support discv5 call which don't need response #31112

GrapeBaBa opened this issue Feb 2, 2025 · 2 comments · May be fixed by #31150

Comments

@GrapeBaBa
Copy link
Contributor

Right now portal network use discv5 based utp packet and it only use talkReq but no need response. Currently in geth code, callCh is used for discv5 request with response, sendCh is used for discv5 response.

Reuse sendCh to send calls that don't require a response, this is a minimal change.

@devlongs
Copy link

devlongs commented Feb 7, 2025

Hi @GrapeBaBa can I work on this issue?

@GrapeBaBa
Copy link
Contributor Author

@devlongs Thanks, however this is what we already added in shisui and need to migrate into the geth code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants