chores(mypy): enforce and fix most rules (only 2 left) (#2285)

* update pyproject toml and fix strict_bytes errors

* fixed 65 warn_unused_ignores errors

* remove comment

* ruff

* ci fix

* fix (last one for realsies)

Author: felix314159

pyproject.toml

@@ -190,6 +190,14 @@ exclude = [
     '^site/',
 ]
 plugins = ["pydantic.mypy"]
+# more rules
+namespace_packages = true
+strict_optional = true
+strict_bytes = true
+warn_unused_ignores = true
+warn_unused_configs = true
+warn_redundant_casts = true
+ignore_missing_imports = false
 
 [tool.codespell]
 skip = ".venv,__pycache__,.git,build,dist,*.pyc,*.lock"

src/cli/evm_bytes.py

@@ -71,12 +71,12 @@ def bytecode(self) -> Bytecode:
 
 
 def process_evm_bytes(evm_bytes: bytes) -> List[OpcodeWithOperands]:  # noqa: D103
-    evm_bytes = bytearray(evm_bytes)
+    evm_bytes_array = bytearray(evm_bytes)
 
     opcodes: List[OpcodeWithOperands] = []
 
-    while evm_bytes:
-        opcode_byte = evm_bytes.pop(0)
+    while evm_bytes_array:
+        opcode_byte = evm_bytes_array.pop(0)
 
         opcode: Op
         for op in Op:
@@ -93,21 +93,21 @@ def process_evm_bytes(evm_bytes: bytes) -> List[OpcodeWithOperands]:  # noqa: D1
                     opcode=opcode,
                     operands=[
                         int.from_bytes(
-                            evm_bytes[: opcode.data_portion_length], "big", signed=signed
+                            evm_bytes_array[: opcode.data_portion_length], "big", signed=signed
                         )
                     ],
                 )
             )
-            evm_bytes = evm_bytes[opcode.data_portion_length :]
+            evm_bytes_array = evm_bytes_array[opcode.data_portion_length :]
         elif opcode == Op.RJUMPV:
-            if len(evm_bytes) == 0:
+            if len(evm_bytes_array) == 0:
                 opcodes.append(OpcodeWithOperands(opcode=opcode))
             else:
-                max_index = evm_bytes.pop(0)
+                max_index = evm_bytes_array.pop(0)
                 operands: List[int] = []
                 for _ in range(max_index + 1):
-                    operands.append(int.from_bytes(evm_bytes[:2], "big", signed=True))
-                    evm_bytes = evm_bytes[2:]
+                    operands.append(int.from_bytes(evm_bytes_array[:2], "big", signed=True))
+                    evm_bytes_array = evm_bytes_array[2:]
                 opcodes.append(OpcodeWithOperands(opcode=opcode, operands=operands))
         else:
             opcodes.append(OpcodeWithOperands(opcode=opcode))

src/cli/extract_config.py

@@ -114,7 +114,7 @@ def create_genesis_from_fixture(fixture_path: Path) -> Tuple[FixtureHeader, Allo
         chain_id = int(fixture.config.chain_id)
     else:
         pre_alloc_group = PreAllocGroup.model_validate(fixture_json)
-        genesis = pre_alloc_group.genesis  # type: ignore
+        genesis = pre_alloc_group.genesis
         alloc = pre_alloc_group.pre
 
     return genesis, alloc, chain_id

src/cli/order_fixtures.py

@@ -41,7 +41,7 @@ def recursive_sort(item: Dict[str, Any] | List[Any]) -> Dict[str, Any] | List[An
         return dict(sorted((k, recursive_sort(v)) for k, v in item.items()))
     elif isinstance(item, list):
         try:
-            return sorted(cast(List[Any], [recursive_sort(x) for x in item]))
+            return sorted(cast(List[Any], [recursive_sort(x) for x in item]))  # type: ignore[redundant-cast]
         except TypeError:
             # If a TypeError is raised, we might be dealing with a list of
             # dictionaries Sort them based on their string representation

src/ethereum_clis/clis/besu.py

@@ -9,7 +9,7 @@
 from pathlib import Path
 from typing import ClassVar, Dict, Optional
 
-import requests  # type: ignore
+import requests
 
 from ethereum_test_exceptions import (
     BlockException,

src/ethereum_test_fixtures/blockchain.py

@@ -225,7 +225,7 @@ def rlp(self) -> Bytes:
         """Compute the RLP of the header."""
         return Bytes(eth_rlp.encode(self.rlp_encode_list))
 
-    @computed_field(alias="hash")  # type: ignore[misc]
+    @computed_field(alias="hash")  # type: ignore[prop-decorator]
     @cached_property
     def block_hash(self) -> Hash:
         """Compute the RLP of the header."""
@@ -481,7 +481,7 @@ class FixtureBlockBase(CamelModel):
         None, description="EIP-7928 Block Access List"
     )
 
-    @computed_field(alias="blocknumber")  # type: ignore[misc]
+    @computed_field(alias="blocknumber")  # type: ignore[prop-decorator]
     @cached_property
     def block_number(self) -> Number:
         """Get the block number from the header."""

src/ethereum_test_fixtures/common.py

@@ -45,7 +45,7 @@ class FixtureAuthorizationTuple(
 ):
     """Authorization tuple for fixture transactions."""
 
-    v: ZeroPaddedHexNumber = Field(validation_alias=AliasChoices("v", "yParity"))  # type: ignore
+    v: ZeroPaddedHexNumber = Field(validation_alias=AliasChoices("v", "yParity"))
     r: ZeroPaddedHexNumber
     s: ZeroPaddedHexNumber
 

src/ethereum_test_forks/tests/test_forks.py

@@ -310,7 +310,7 @@ def pre_allocation(cls, *, block_number: int = 0, timestamp: int = 0) -> Dict:
         return {"test2": "test2"} | super(PreAllocFork, cls).pre_allocation()
 
 
-@transition_fork(to_fork=PreAllocFork, at_timestamp=15_000)  # type: ignore
+@transition_fork(to_fork=PreAllocFork, at_timestamp=15_000)
 class PreAllocTransitionFork(PrePreAllocFork):
     """PrePreAllocFork to PreAllocFork transition at Timestamp 15k."""
 

src/ethereum_test_forks/transition_base_fork.py

@@ -39,7 +39,7 @@ def decorator(cls) -> Type[TransitionBaseClass]:
         assert issubclass(from_fork, BaseFork)
 
         class NewTransitionClass(
-            cls,  # type: ignore
+            cls,
             TransitionBaseClass,
             BaseFork,
             transition_tool_name=cls._transition_tool_name,

src/ethereum_test_specs/eof.py

@@ -118,9 +118,7 @@ def __init__(self, code: Bytes, expected: str, got: str):
         super().__init__(message)
 
 
-class EOFExceptionWithMessage(
-    ExceptionWithMessage[EOFException]  # type: ignore
-):
+class EOFExceptionWithMessage(ExceptionWithMessage[EOFException]):
     """Exception returned from the eof validator with a message."""
 
     pass