You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unfortunately both do not really separate the data from code.
Data-Format wise I think we can collapse the gazillion fields of the ethereum-org data by introducing arrays for supported platforms, standards, features and socials.
I am struggling a bit with how to deal with variants currently. E.g. if a wallet exists for desktop and mobile - they will have different support status for e.g. EIP-6963. I am leaning as then seeing them as completely different wallets instead of having conditional properties - but this will lead to some duplication. So maybe we should have a way to have "base properties" that can be delegated to. So we have e.g. 2 wallets "MetaMask mobile" and "MetaMask desktop" and both delegate to some "MetaMask base"
The text was updated successfully, but these errors were encountered:
What I would also really love the data can express is (hardware) wallet compatibility. Currently e.g. in the ethereumorg repo this is boiled down to a simple boolean field hardware_support - but it would be really nice to encode which hardware wallets are supported - and not only the fact that (at least) one is. This could be referencing the wallets directly in the dataset (same as the "parent" field for LX chains in ethereum-lists/chains)
we could take initial data from:
https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/wallets/wallet-data.ts
and about EIP-6963 support from here:
https://github.com/WalletConnect/EIP6963/blob/master/src/utils/constants.ts
Another source: https://github.com/fluidkey/walletbeat/blob/main/src/data/data.ts
Unfortunately both do not really separate the data from code.
Data-Format wise I think we can collapse the gazillion fields of the ethereum-org data by introducing arrays for supported platforms, standards, features and socials.
I am struggling a bit with how to deal with variants currently. E.g. if a wallet exists for desktop and mobile - they will have different support status for e.g. EIP-6963. I am leaning as then seeing them as completely different wallets instead of having conditional properties - but this will lead to some duplication. So maybe we should have a way to have "base properties" that can be delegated to. So we have e.g. 2 wallets "MetaMask mobile" and "MetaMask desktop" and both delegate to some "MetaMask base"
The text was updated successfully, but these errors were encountered: