Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial data / structure #1

Open
ligi opened this issue Dec 5, 2023 · 1 comment
Open

Initial data / structure #1

ligi opened this issue Dec 5, 2023 · 1 comment

Comments

@ligi
Copy link
Member

ligi commented Dec 5, 2023

we could take initial data from:
https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/wallets/wallet-data.ts
and about EIP-6963 support from here:
https://github.com/WalletConnect/EIP6963/blob/master/src/utils/constants.ts
Another source: https://github.com/fluidkey/walletbeat/blob/main/src/data/data.ts

Unfortunately both do not really separate the data from code.

Data-Format wise I think we can collapse the gazillion fields of the ethereum-org data by introducing arrays for supported platforms, standards, features and socials.
I am struggling a bit with how to deal with variants currently. E.g. if a wallet exists for desktop and mobile - they will have different support status for e.g. EIP-6963. I am leaning as then seeing them as completely different wallets instead of having conditional properties - but this will lead to some duplication. So maybe we should have a way to have "base properties" that can be delegated to. So we have e.g. 2 wallets "MetaMask mobile" and "MetaMask desktop" and both delegate to some "MetaMask base"

@ligi
Copy link
Member Author

ligi commented Dec 5, 2023

What I would also really love the data can express is (hardware) wallet compatibility. Currently e.g. in the ethereumorg repo this is boiled down to a simple boolean field hardware_support - but it would be really nice to encode which hardware wallets are supported - and not only the fact that (at least) one is. This could be referencing the wallets directly in the dataset (same as the "parent" field for LX chains in ethereum-lists/chains)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant