Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 0x48c6740bcf807d6c47c864faeea15ed4da3910ab #937

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add 0x48c6740bcf807d6c47c864faeea15ed4da3910ab #937

wants to merge 6 commits into from

Conversation

JasperOPR
Copy link

@JasperOPR JasperOPR commented Jan 27, 2025 •
edited
Loading

ligi
ligi requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The address is not valid with ERC-55 checksum 0x48c6740bcf807d6c47c864faeea15ed4da3910ab expected: 0x48C6740BcF807d6C47C864FaEEA15Ed4dA3910Ab

ligi
ligi requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename must be the address + .json

@JasperOPR
Copy link
Author

Filename must be the address + .json

it's already in .json

or not?

@ligi
Copy link
Member

ligi commented Feb 2, 2025

not the same address

jasperOPR added 2 commits February 6, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasperOPR @ligi