-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API v2 #1889
Comments
I would add a "isTestnet" boolean, useful to all indexers/trackers/DEXes/etc. |
My reasoning for not wanting isTestNet: #2351 |
your reasoning is "Goerli has now value, people test on Mainnet".. |
The lines are really blurry. I really do not think a boolean flag makes sense here. |
I'm not saying YOU should take the decision and that a boolean value
decides if the token can have market value, I'm just saying having a
canonical test value, defined by the entity adding the chain to the list,
could help many users of this service. Do you recognize the utility? Can
you offer alternative means to select which chains I should connect to with
my production service? Thank you.
Il giorno lun 17 apr 2023 alle ore 16:11 ligi ***@***.***> ha
scritto:
… The lines are really blurry. I really do not think a boolean flag makes
sense here.
—
Reply to this email directly, view it on GitHub
<#1889 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABECMLYDPQ3JFPRYGRJXHLTXBVFQDANCNFSM6AAAAAASEECH7A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
but in the end I need to review the PR - not sure how I can meaningfully do this for that value as I think it is not boolean. |
API v2 should change faucets (#1884) and RPC (some ideas here #1829 (comment))
old data format should be kept for a while (as output) - new one added at /v2 - fallback should be possible with these both changes
The text was updated successfully, but these errors were encountered: