Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update componentWillReceiveProps #68

Open
lhtdesignde opened this issue Oct 30, 2019 · 4 comments
Open

Update componentWillReceiveProps #68

lhtdesignde opened this issue Oct 30, 2019 · 4 comments

Comments

@lhtdesignde
Copy link

This lifecycle function is deprecated. Would be great if you could add UNSAFE prefix or generally refactor it to componentDidUpdate.

Warning: componentWillReceiveProps has been renamed, and is not recommended for use.
See https://fb.me/react-unsafe-component-lifecycles for details.
* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps.
Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work.
To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.
Please update the following components: EnlargedImage

Thanks!

@ceisele-r
Copy link

Actually I think this will break completely in react 17 since those methods can then only be called with the unsafe_ name.

@hiahmedhameed
Copy link

hiahmedhameed commented May 28, 2020

Hello @ethanselzer,
Thank you for the nice library.

Do we expect any update regarding this warning soon ?

@spasticninja
Copy link

Version of react-image-magnify: 2.7.4

  console.warn
    Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

    * Move data fetching code or side effects to componentDidUpdate.
    * If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
    * Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

    Please update the following components: ReactCursorPosition

@a-tonchev
Copy link

Issue still here, probably we need to make a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants