Draw overlay layer later in grid square instead of last (#401)

Author: ethanmoffat

EndlessClient/Rendering/Map/MapEntityRendererProvider.cs

@@ -59,11 +59,6 @@ public MapEntityRendererProvider(INativeGraphicsManager nativeGraphicsManager,
                                         gridDrawCoordinateCalculator,
                                         clientWindowSizeProvider,
                                         configurationProvider),
-                new OverlayLayerRenderer(nativeGraphicsManager,
-                                         currentMapProvider,
-                                         characterProvider,
-                                         gridDrawCoordinateCalculator,
-                                         clientWindowSizeProvider),
                 new MapObjectLayerRenderer(nativeGraphicsManager,
                                            currentMapProvider,
                                            characterProvider,
@@ -92,6 +87,11 @@ public MapEntityRendererProvider(INativeGraphicsManager nativeGraphicsManager,
                                                  currentMapStateProvider,
                                                  gridDrawCoordinateCalculator,
                                                  clientWindowSizeProvider),
+                new OverlayLayerRenderer(nativeGraphicsManager,
+                                         currentMapProvider,
+                                         characterProvider,
+                                         gridDrawCoordinateCalculator,
+                                         clientWindowSizeProvider),
                 new NPCEntityRenderer(characterProvider,
                                       gridDrawCoordinateCalculator,
                                       clientWindowSizeProvider,

EndlessClient/Rendering/MapEntityRenderers/BaseMapEntityRenderer.cs

@@ -38,9 +38,7 @@ static BaseMapEntityRenderer()
 
         public abstract MapRenderLayer RenderLayer { get; }
 
-        public bool ShouldRenderLast => RenderLayer == MapRenderLayer.Overlay ||
-                                        RenderLayer == MapRenderLayer.Overlay2 ||
-                                        RenderLayer == MapRenderLayer.MainCharacterTransparent;
+        public bool ShouldRenderLast => RenderLayer == MapRenderLayer.Overlay2 || RenderLayer == MapRenderLayer.MainCharacterTransparent;
 
         protected abstract int RenderDistance { get; }