Replies: 3 comments
-
I had the same idea but I don't think it is good to think of refactoring types file now, however it is a good idea but may lead to some breaking changes. @Badiboy Ur opinion? |
Beta Was this translation helpful? Give feedback.
-
I don't think it will bring something valuable. It may reduce some code in types, but that code is not a significant problem... |
Beta Was this translation helpful? Give feedback.
-
In my opinion, useful, popular and long-lived projects like this one (by the way, many thanks for the great work), the ease of code maintenance becomes a key value. And code amount reduction plays an important role here. |
Beta Was this translation helpful? Give feedback.
-
At this manner: https://github.com/vb64/telemulator3/blob/main/telemulator3/dictionaryable.py
This will reduce the amount of code in telebot.types and make it easier to add Dictionaryable functionality to the other telebot.types classes.
If it is deemed useful, I can prepare a PR.
Beta Was this translation helpful? Give feedback.
All reactions