Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rst signal according to _neg / _pos #63

Open
stdefeber opened this issue Jun 26, 2024 · 1 comment
Open

Change rst signal according to _neg / _pos #63

stdefeber opened this issue Jun 26, 2024 · 1 comment
Labels
kind: refactoring Rewriting existing code without new features being introduced scope: hw generators Related to HDL generators status: todo Planned for implementation
Milestone
v2.0.0

Comments

@stdefeber
Copy link

Currently the reset signal is always defined as "rst".
When one sets the register_reset to "_neg" the signal does not reflect the active state anymore.

So would it be possible to make it "rstn" when register_reg = <>_neg ?
@esynr3z esynr3z added the kind: feature New feature or request of enhancement label Oct 5, 2024
@esynr3z esynr3z changed the title #enhancement : Change rst signal according to _neg / _pos Change rst signal according to _neg / _pos Oct 5, 2024
@esynr3z esynr3z added new New issue not seen by maintainers scope: hw generators Related to HDL generators labels Oct 5, 2024
@esynr3z esynr3z added this to the v2.0.0 milestone Oct 5, 2024
@esynr3z
Copy link
Owner

esynr3z commented Oct 12, 2024

Yes it would be possible. For now, this was done intentionally in order to simplify templates. However, it looks like simple jinja macro is required.

@esynr3z esynr3z added kind: refactoring Rewriting existing code without new features being introduced status: todo Planned for implementation and removed kind: feature New feature or request of enhancement new New issue not seen by maintainers labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: refactoring Rewriting existing code without new features being introduced scope: hw generators Related to HDL generators status: todo Planned for implementation
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@stdefeber @esynr3z