Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect clusterrole #57

Merged
merged 2 commits into from
Nov 19, 2019
Merged

fix incorrect clusterrole #57

merged 2 commits into from
Nov 19, 2019

Conversation

JorritSalverda
Copy link
Collaborator

@JorritSalverda JorritSalverda commented Nov 19, 2019

Restores the ClusterRole to it's original version at https://github.com/estafette/estafette-gke-preemptible-killer/pull/43/files#diff-0d3db36ca60f7f38c816d42593594ae1 which was incorrectly set when creating the official Helm chart.

Fixes #55
Fixes #52

@phroggyy
Copy link

This will solve #56, but not the greater problem brought up in #55. Should we keep #55 open for discussion to ensure we can build a sustainable way of keeping them in sync?

@JorritSalverda JorritSalverda merged commit 8ae5a0e into master Nov 19, 2019
@JorritSalverda JorritSalverda deleted the fix-clusterrole branch November 19, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The cluster role in the helm chart should match the one in the manifest Incomplete Documentation
3 participants