Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cluster role in the helm chart should match the one in the manifest #55

Open
phroggyy opened this issue Nov 18, 2019 · 1 comment · Fixed by #57
Open

The cluster role in the helm chart should match the one in the manifest #55

phroggyy opened this issue Nov 18, 2019 · 1 comment · Fixed by #57

Comments

@phroggyy
Copy link

As per #53 (comment) and the comment prior, the cluster role should not have access to secrets and events.

This is clear from the fact that these permissions are only granted in the helm chart, and not in the non-helm manifests.

For further discussion: is there a good way to keep those in sync? Can we have helm read the manifests as yaml and grab segments, or even have a CI job that'll auto-update parts? (e.g doing a helm template with given values that output the desired files).

@JorritSalverda
Copy link
Collaborator

Ah, I didn't add the manifests, so wasn't looking at keeping them up to date; I'd rather find a simple way to document combining kontemplate with Helm or to automatically generate those templates from the Helm files, so they're leading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants