Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 2182f88

Browse files
committedOct 11, 2022
fix: fix description of resolution in docs and examples
1 parent 108a330 commit 2182f88

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed
 

‎README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,10 @@ static camera_config_t camera_config = {
152152
.ledc_channel = LEDC_CHANNEL_0,
153153

154154
.pixel_format = PIXFORMAT_JPEG,//YUV422,GRAYSCALE,RGB565,JPEG
155-
.frame_size = FRAMESIZE_UXGA,//QQVGA-QXGA Do not use sizes above QVGA when not JPEG
155+
.frame_size = FRAMESIZE_UXGA,//QQVGA-UXGA, For ESP32, do not use sizes above QVGA when not JPEG. The performance of the ESP32-S series has improved a lot, but JPEG mode always gives better frame rates.
156156

157-
.jpeg_quality = 12, //0-63 lower number means higher quality
158-
.fb_count = 1, //if more than one, i2s runs in continuous mode. Use only with JPEG
157+
.jpeg_quality = 12, //0-63, for OV series camera sensors, lower number means higher quality
158+
.fb_count = 1, //When jpeg mode is used, if fb_count more than one, the driver will work in continuous mode.
159159
.grab_mode = CAMERA_GRAB_WHEN_EMPTY//CAMERA_GRAB_LATEST. Sets when buffers should be filled
160160
};
161161

‎examples/main/take_picture.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,10 @@ static camera_config_t camera_config = {
120120
.ledc_channel = LEDC_CHANNEL_0,
121121

122122
.pixel_format = PIXFORMAT_RGB565, //YUV422,GRAYSCALE,RGB565,JPEG
123-
.frame_size = FRAMESIZE_QVGA, //QQVGA-UXGA Do not use sizes above QVGA when not JPEG
123+
.frame_size = FRAMESIZE_QVGA, //QQVGA-UXGA, For ESP32, do not use sizes above QVGA when not JPEG. The performance of the ESP32-S series has improved a lot, but JPEG mode always gives better frame rates.
124124

125-
.jpeg_quality = 12, //0-63 lower number means higher quality
126-
.fb_count = 1, //if more than one, i2s runs in continuous mode. Use only with JPEG
125+
.jpeg_quality = 12, //0-63, for OV series camera sensors, lower number means higher quality
126+
.fb_count = 1, //When jpeg mode is used, if fb_count more than one, the driver will work in continuous mode.
127127
.grab_mode = CAMERA_GRAB_WHEN_EMPTY,
128128
};
129129

‎test/test_camera.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ static esp_err_t init_camera(uint32_t xclk_freq_hz, pixformat_t pixel_format, fr
147147
.ledc_channel = LEDC_CHANNEL_0,
148148

149149
.pixel_format = pixel_format, //YUV422,GRAYSCALE,RGB565,JPEG
150-
.frame_size = frame_size, //QQVGA-UXGA Do not use sizes above QVGA when not JPEG
150+
.frame_size = frame_size, //QQVGA-UXGAQQVGA-UXGA, For ESP32, do not use sizes above QVGA when not JPEG. The performance of the ESP32-S series has improved a lot, but JPEG mode always gives better frame rates.
151151

152-
.jpeg_quality = 12, //0-63 lower number means higher quality
153-
.fb_count = fb_count, //if more than one, i2s runs in continuous mode. Use only with JPEG
152+
.jpeg_quality = 12, //0-63, for OV series camera sensors, lower number means higher quality
153+
.fb_count = fb_count, //When jpeg mode is used, if fb_count more than one, the driver will work in continuous mode.
154154
.grab_mode = CAMERA_GRAB_WHEN_EMPTY
155155
};
156156

0 commit comments

Comments
 (0)
Please sign in to comment.