CTRL-C doesn't work anymore (Windows 11)

[bjoernQ]

On master ( 2e9347d34d41d9e59b62a2293bae41a7c193bb27 ) CTRL-C doesn't work anymore (Windows 11 at least) when running with --monitor

Need to check when exactly that broke - not tested on other platforms yet

[bjoernQ]

Worked at least on commit eeb0e8f95d184209cc42be9c4fec15c7172729fc

[jessebraham]

This line is the only real change I see to the monitor since the working commit hash you've posted. Sorry to be a bother, would you be able to confirm that this is the commit which caused the problem please?

[bjoernQ]

Sorry I wanted to look into this already by myself but got distracted by some linker issues ....

However, I found something!

The root cause seems to be mentioned in crossterm-rs/crossterm#629

If I change

espflash/espflash/src/cli/monitor.rs

Line 123 in 2e9347d

KeyCode::Char('c') => break,

to KeyCode::Char('C') => break, it works again - but certainly would break things on other platforms.

So, we could wait for the next crossterm release or add a temporary fix by adding the uppercase cases there, too. I personally can live with this since I use a locally compiled espflash where I can patch this but probably others will run into that issue in the meantime

I have no idea when to expect the next release of crossterm containing the fix. (I tried it with the main branch and then it works without changes on our side)

[jessebraham]

Changing:

espflash/espflash/src/cli/monitor.rs

Lines 123 to 124 in 2e9347d

	KeyCode::Char('c') => break,
	KeyCode::Char('r') => {

To:

KeyCode::Char('c') | KeyCode::Char('C') => break, 
KeyCode::Char('r') | KeyCode::Char('R') => { 

Should resolve this for the time being, no? I can say that on macOS Big Sur I do not experience this problem even without the fix, but it continues to work for me using this modification.

[bjoernQ]

That should resolve it without breaking MacOS or Linux. And even when crossterm gets the fix it should still work.

[WindSoilder]

Hi, Sorry for introcing a bug like this in crossterm, for now the new version 0.23.1 is fixed.