Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does esp-hal-procmacros need to be stable also? #3078

Open
MabezDev opened this issue Jan 31, 2025 · 2 comments
Open

Does esp-hal-procmacros need to be stable also? #3078

MabezDev opened this issue Jan 31, 2025 · 2 comments
Labels
1.0-blocker package:esp-hal-procmacros Issues related to the esp-hal-procmacros package RFC Request for comment

Comments

@MabezDev
Copy link
Member

As part of not having dependencies <1.0 in the public API.

I assumed this was a yes and was going to open a separate issue, but looking at the docs it seems like macro reexports work a bit differently?

Take a look at https://docs.esp-rs.org/esp-hal/esp-hal/0.23.1/esp32c6/esp_hal/#attributes clicking on any macro and rustdoc seems to think the macro comes from esp-hal itself. If this is the case, it's great because we really only have to worry about esp-hal in this case.

@MabezDev MabezDev added 1.0-blocker package:esp-hal-procmacros Issues related to the esp-hal-procmacros package labels Jan 31, 2025
@MabezDev MabezDev added the RFC Request for comment label Jan 31, 2025
@bjoernQ
Copy link
Contributor

bjoernQ commented Feb 3, 2025

Yes looks like this for me

@bugadani
Copy link
Contributor

bugadani commented Feb 3, 2025

We probably want to make it clear that we don't intend to stabilize procmacros and directly depending on that crate is not supported. With that, we can keep the crate unstable, but we also can't really introduce breaking changes into the reexported macros, which needs some care on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0-blocker package:esp-hal-procmacros Issues related to the esp-hal-procmacros package RFC Request for comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants